Enforce length checking for user name field

Bug #1279579 reported by Yuanhui Liu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Zhenguo Niu

Bug Description

Currently in User update, there is no checking on the user name length. But once the form is submitted, the system actually checked the length of the user name and reported error on that, as shown below:

Recoverable error: User name should not be greater than 255 characters. (HTTP 400)

It would be better checking this on the front end.

Yuanhui Liu (liuyu)
Changed in horizon:
assignee: nobody → Yuanhui Liu (liuyu)
Yuanhui Liu (liuyu)
Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73427

Revision history for this message
Tatiana Ovchinnikova (tmazur) wrote :
Revision history for this message
Julie Pichon (jpichon) wrote :

The fix for the other patch only handled the length restriction in "Create" so perhaps we can keep this bug open to add the restriction in "Update" as well.

description: updated
Revision history for this message
Zhenguo Niu (niu-zglinux) wrote :

I have updated the bug description for only User Update Form, and will resubmit a patch since there is no response from YuanHui for a long time.

Changed in horizon:
assignee: Yuanhui Liu (liuyu) → Zhenguo Niu (niu-zglinux)
importance: Undecided → Low
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/128819

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Zhenguo Niu (<email address hidden>) on branch: master
Review: https://review.openstack.org/73427

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/128819
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a696e5992e58ac65240df5f226000705c3370365
Submitter: Jenkins
Branch: master

commit a696e5992e58ac65240df5f226000705c3370365
Author: Zhenguo Niu <email address hidden>
Date: Thu Oct 16 11:26:02 2014 +0800

    Restrict the length of user name input

    When updating users, user name should not be greater than 255.

    Change-Id: Icf99fc2adec8d3a044cca4486f332593a91474fa
    Closes-Bug: #1279579

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.