instance_get_all_by_filters() got an unexpected keyword argument 'use_slave'

[Andrew Laski]

2014-02-12 06:25:32.429 12188 ERROR nova.openstack.common.periodic_task [-] Error during ComputeManager._poll_rescued_instances: instance_get_all_by_filters() got an unexpected keyword argument 'use_slave'
2014-02-12 06:25:32.429 12188 TRACE nova.openstack.common.periodic_task Traceback (most recent call last):
2014-02-12 06:25:32.429 12188 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/592.0/nova/lib/python2.6/site-packages/nova/openstack/common/periodic_task.py", line 182, in run_periodic_tasks
2014-02-12 06:25:32.429 12188 TRACE nova.openstack.common.periodic_task task(self, context)
2014-02-12 06:25:32.429 12188 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/592.0/nova/lib/python2.6/site-packages/nova/compute/manager.py", line 4786, in _poll_rescued_instances
2014-02-12 06:25:32.429 12188 TRACE nova.openstack.common.periodic_task use_slave=True)
2014-02-12 06:25:32.429 12188 TRACE nova.openstack.common.periodic_task TypeError: instance_get_all_by_filters() got an unexpected keyword argument 'use_slave'

commit e8ab7ffb7274190105a3289cc1a3ed1d9ab5feb8 added the use_slave parameter to some db calls. The parameter was added to the db calls themselves, and the instance NovaObject, but the conductor api for the instance_get_all_by_filters call was missed. This causes the the _poll_rescued_instances periodic task to error on each run.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/72965

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72965
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=50b833d2c059ab43f0b6a7b84e4efa8169580edf
Submitter: Jenkins
Branch: master

commit 50b833d2c059ab43f0b6a7b84e4efa8169580edf
Author: Andrew Laski <email address hidden>
Date: Wed Feb 12 10:10:58 2014 -0500

    Add 'use_slave' to instance_get_all_by_filter in conductor

    When the use_slave parameter was added to instance_get_all_by_filter in
    the db layer and nova object layer it was missed in conductor, causing a
    failure in the _poll_rescued_instances periodic task. This adds the
    parameter where necessary.

    Change-Id: I16ab29730d72b2e2941766b5b12568976facec39
    Closes-bug: 1279358