Two LBaaS tests are identical

Bug #1279276 reported by Tatiana Ovchinnikova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Tatiana Ovchinnikova

Bug Description

The tests:

@test.create_stubs({api.neutron: ('network_list_for_tenant',
                                      'provider_list',
                                      'is_extension_supported')})
def test_add_pool_get(self):
        self._test_add_pool_get(with_service_type=True)

and

@test.create_stubs({api.neutron: ('network_list_for_tenant',
                                      'provider_list',
                                      'is_extension_supported')})
def test_add_pool_get_provider_list_exception(self):
        self._test_add_pool_get(with_service_type=True)

should differ.

Changed in horizon:
assignee: nobody → Tatiana Mazur (tmazur)
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/72916

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/72916
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cf252d2252fe245eccdc70a726894069a4113ad7
Submitter: Jenkins
Branch: master

commit cf252d2252fe245eccdc70a726894069a4113ad7
Author: Tatiana Mazur <email address hidden>
Date: Wed Feb 12 14:03:22 2014 +0400

    Make two identical LBaaS tests different

    The argument for "test_add_pool_get_provider_list_exception"
    should be "with_provider_exception". Moreover, in
    "test_add_pool_get" the argument "with_service_type=True"
    is redundant since True is default value.

    Closes-Bug: #1279276

    Change-Id: I669eb34634fa7169165aff1ef2d5a3ee77c026ad

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.