[hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false.

Bug #1279257 reported by dcb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QEMU
Fix Released
Undecided
Unassigned

Bug Description

Source code is

       } else if ((buf[1] & 4) == 1) {

Suggest code rework. I found this bug by running
static analyser cppcheck over the source code.

I also checked the latest code on the web and the
bug exists there also.

Revision history for this message
Thomas Huth (th-huth) wrote :

Looks like this has been fixed here already:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=7ef8cf9a0861b6f67f5e

Changed in qemu:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.