get_spice_console should catch NotImplement exception and handle it

Bug #1279195 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
jichenjc

Bug Description

in v2/v3 API layer
def get_spice_console(self, req, id, body):

didn't catch NotImplement exception and handle it

jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichencom (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/72869

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/72869
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f52a7f181ab8eb7b9e3e780183662fde8755cabd
Submitter: Jenkins
Branch: master

commit f52a7f181ab8eb7b9e3e780183662fde8755cabd
Author: jichenjc <email address hidden>
Date: Tue Jan 28 10:19:26 2014 +0800

    Catch NotImplementedError in get_spice_console in v2/v3 API

    Currently get_spice_console doesn't catch NotImpelementedError
    and it will lead to inaccurate information returned back
    to API caller. This patch adds the catch exception routine and
    returns a HTTPNotImplemented excpetion.

    Closes-Bug: #1279195
    Change-Id: I16cb0a83c0e1aa9a041dd21af324a39388ca3bb8

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.