resize instance - flavors not sorted

[Cindy Lu]

New Flavor dropdown menu should be sorted by RAM or something.

[Julie Pichon (jpichon)]

It looks like they are sorted by flavor id at the moment.

https://github.com/openstack/horizon/blob/1fdac75d4fe1511fd226666aa2e43b32aa6380ad/openstack_dashboard/dashboards/project/instances/views.py#L274

It would be good to reuse the CREATE_INSTANCE_FLAVOR_SORT setting and default, to be consistent with the Launch Instance menu.

https://github.com/openstack/horizon/blob/a63cfc102b13c7376ad5445b218333643cbda258/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L295
https://github.com/openstack/horizon/blob/759e497b0d/openstack_dashboard/local/local_settings.py.example#L227

(and while at it, it would be nice to add documentation about this setting to http://docs.openstack.org/developer/horizon/topics/settings.html !)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/73095

[Cindy Lu (clu-m)]

Hi,

I didn't add the CREATE_INSTANCE_FLAVOR_SORT setting to the documentation page because it seemed a little out of place. It is such a minor config setting.

Please let me know if you think differently.

Thanks :)

[Julie Pichon (jpichon)]

Personally I'd love to have an exhaustive list of settings I can point people to (cf. bug 1221115), rather than have some settings defined only in local_settings.py.example, other in the docs, and other nowhere except in the code. I think it's confusing and makes neat features less discoverable. Please consider adding it :) Thank you!

(...of course we'll definitely need to improve the layout of the settings page at some point, to avoid overwhelming people!)

[Cindy Lu (clu-m)]

Thank you for linking me to that bug, Julie. Will do. :)

[Cindy Lu (clu-m)]

Also, do you know how to generate the settings.html so that I can double check the things are okay? I tried to use the sphinx-build command to no avail. Thanks!

[Julie Pichon (jpichon)]

@clu-m: Thanks! I normally use `./run_tests.sh --docs` to generate the documentation. If that doesn't work feel free to pop on #openstack-horizon on IRC so we can try and debug it.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73095
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=19eac27aa62e087d7bb5e9eb3d0220a003693f08
Submitter: Jenkins
Branch: master

commit 19eac27aa62e087d7bb5e9eb3d0220a003693f08
Author: Cindy Lu <email address hidden>
Date: Mon Feb 24 14:45:28 2014 -0800

    sort flavors on Resize Instance modal

    in the new flavor dropdown menu, it is sorted by id right now,
    changed so that it matches that in create instance, sorted
     by ascending RAM usage

    I refactored out the common flavor sorting code into instances/util.py
    that is shared by create_instance and resize_instance

    Change-Id: I40dedcf87dbcfb7128185445510d9ec96462abb2
    Closes-Bug: #1279135