MAAS

maas_ipmi_autodetect.py ignores command failures

Bug #1279107 reported by Jason Hobbs
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Jason Hobbs
MAAS 14.04 "trusty"

Bug Description

maas_ipmi_autodetect.py uses commands.getstatusoutput to run commands, but never checks the value of status after running commands. This means commands can silently fail.

Revision: 1927

Tags: server-hwe

Related branches

lp:~jason-hobbs/maas/lp-1279107
Andres Rodriguez (community): Approve
Gavin Panella (community): Approve
Julian Edwards (community): Approve
Diff: 304 lines (+171/-35)
5 files modified
buildout.cfg (+4/-1)
etc/maas/templates/commissioning-user-data/snippets/maas_ipmi_autodetect.py (+58/-34)
etc/maas/templates/commissioning-user-data/snippets/tests/test_maas_ipmi_autodetect.py (+107/-0)
src/metadataserver/commissioning/snippets.py (+1/-0)
src/metadataserver/commissioning/tests/test_snippets.py (+1/-0)
Jason Hobbs (jason-hobbs)
Changed in maas:
assignee: nobody → Jason Hobbs (jason-hobbs)
Julian Edwards (julian-edwards)
Changed in maas:
status: New → Triaged
importance: Undecided → Critical
milestone: none → 14.04
status: Triaged → In Progress
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Jason Hobbs (jason-hobbs)
tags: added: server-hwe
Julian Edwards (julian-edwards)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.