trove-manage update datastore fails when default_version is provided, but does not exist in the db

[Ionuț Arțăriși]

2014-02-11 17:33:16.825 27083 INFO trove.db.sqlalchemy.session [-] Creating SQLAlchemy engine with args: {'pool_recycle': 3600, 'echo': False}
Command failed, please check log for more info
2014-02-11 17:33:16.931 27083 CRITICAL root [-] local variable 'version' referenced before assignment
2014-02-11 17:33:16.931 27083 TRACE root Traceback (most recent call last):
2014-02-11 17:33:16.931 27083 TRACE root File "/usr/bin/trove-manage", line 10, in <module>
2014-02-11 17:33:16.931 27083 TRACE root sys.exit(main())
2014-02-11 17:33:16.931 27083 TRACE root File "/usr/lib64/python2.6/site-packages/trove/cmd/manage.py", line 126, in main
2014-02-11 17:33:16.931 27083 TRACE root Commands().execute()
2014-02-11 17:33:16.931 27083 TRACE root File "/usr/lib64/python2.6/site-packages/trove/cmd/manage.py", line 59, in execute
2014-02-11 17:33:16.931 27083 TRACE root exec_method(**kwargs)
2014-02-11 17:33:16.931 27083 TRACE root File "/usr/lib64/python2.6/site-packages/trove/cmd/manage.py", line 64, in datastore_update
2014-02-11 17:33:16.931 27083 TRACE root default_version)
2014-02-11 17:33:16.931 27083 TRACE root File "/usr/lib64/python2.6/site-packages/trove/datastore/models.py", line 202, in update_datastore
2014-02-11 17:33:16.931 27083 TRACE root datastore.default_version_id = version.id
2014-02-11 17:33:16.931 27083 TRACE root UnboundLocalError: local variable 'version' referenced before assignment
2014-02-11 17:33:16.931 27083 TRACE root

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/72701

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72701
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=57d7950f85368bd41e8f3660c8bce7f2728f71f3
Submitter: Jenkins
Branch: master

commit 57d7950f85368bd41e8f3660c8bce7f2728f71f3
Author: Ionuț Arțăriși <email address hidden>
Date: Tue Feb 11 17:49:21 2014 +0100

    fix traceback when default_version is not in the database

    This commit lets the right error be raised which ends up in the cli as
    e.g:

    Datastore version '5.5' cannot be found.

    Change-Id: I636bf43d135b2143f2a3bd1878215d7ec270330e
    Closes-Bug: #1278965