::proxy class requires for middlewares doesn't handle underscores

Bug #1278950 reported by David Moreau Simard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-swift
Fix Released
Undecided
David Moreau Simard
Havana
Fix Committed
Undecided
David Moreau Simard

Bug Description

swift::proxy::proxy-logging was deprecated in favor of swift::proxy::proxy_logging since hyphens are not recommended for puppet classes.

The current code will expect proxy-logging to be in the catalog while we want proxy_logging.

There is an inline template is swift::proxy that ensures that every middleware in the pipeline has it's class included in the catalog.
It needs to be changed in order to support the above use case (and possible future middlewares that may have hyphens in them)

https://github.com/stackforge/puppet-swift/blob/master/manifests/proxy.pp#L95-L101

  $required_classes = split(
    inline_template(
      "<%=
          (pipeline - ['proxy-server']).collect do |x|
            'swift::proxy::' + x
          end.join(',')
      %>"), ',')

Changed in puppet-swift:
assignee: nobody → David Moreau Simard (dmsimard)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/72693

Changed in puppet-swift:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.openstack.org/72693
Committed: https://git.openstack.org/cgit/stackforge/puppet-swift/commit/?id=af45e4200ecc26fc34df2f785b79eb89426bd69b
Submitter: Jenkins
Branch: master

commit af45e4200ecc26fc34df2f785b79eb89426bd69b
Author: David Moreau Simard <email address hidden>
Date: Tue Feb 11 11:17:02 2014 -0500

    Add support for middlewares with hyphens

    Change-Id: I1142270f76285190b600da759753011331a85909
    Closes-bug: #1278950

Changed in puppet-swift:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/74082

Changed in puppet-swift:
status: Fix Committed → Fix Released
Mathieu Gagné (mgagne)
Changed in puppet-swift:
status: Fix Released → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/havana)

Reviewed: https://review.openstack.org/74082
Committed: https://git.openstack.org/cgit/stackforge/puppet-swift/commit/?id=9eef6db87c92ed5b6327e63811da13b088df6d35
Submitter: Jenkins
Branch: stable/havana

commit 9eef6db87c92ed5b6327e63811da13b088df6d35
Author: David Moreau Simard <email address hidden>
Date: Tue Feb 11 11:17:02 2014 -0500

    Add support for middlewares with hyphens

    Change-Id: I1142270f76285190b600da759753011331a85909
    Closes-bug: #1278950
    (cherry picked from commit af45e4200ecc26fc34df2f785b79eb89426bd69b)

Mathieu Gagné (mgagne)
Changed in puppet-swift:
milestone: none → 4.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.