Insufficient upper bounds checking performed on flavor-create API

[John Warren]

The fix for bug #1243195 added upper-bound checking for flavor fields based on sys.maxint. The problem is that the value of maxint varies by platform (either 32- or 64-bit signed integers), while the INTEGER type in databases is limited to 32-bit signed integers. This means that the upper-bound checking does not work on platforms where sys.maxint returns the maximum value of a 64-bit signed integer. The original reported problems (as shown in http://paste.openstack.org/show/48988/) persist on 64-bit platforms.

[Matt Riedemann (mriedem)]

https://review.openstack.org/#/c/72704/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72704
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8d2d72559ce8b371532e2e87912bd7ef74ccb8b3
Submitter: Jenkins
Branch: master

commit 8d2d72559ce8b371532e2e87912bd7ef74ccb8b3
Author: John Warren <email address hidden>
Date: Tue Feb 11 17:06:07 2014 +0000

    Fix upper bound checking for flavor create parameters

    Fix flavor-create upper bound checking so it uses platform-independent
    32-bit max signed integer value instead of sys.maxint, which causes
    problems on 64-bit platforms. The DB int type is a 32-bit signed
    integer, regardless of platform.

    Change-Id: I82624121a45f6385d3ea9ae9c032109834584fac
    Closes-bug: 1278939