build completion status not translated
Bug #1278583 reported by
Kai
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Low
|
Unassigned |
Bug Description
This is just a minor minor bug - just wanted to report it anyway. It looks like even with the 18rc some strings are not translated. I've noticed it with the build status.
Steps to reproduce:
- start widelands
- create a new game
- enable display of building statistics
- start to build any building
- instead of a translated text (e.g. "0 % fertiggestellt" the english text "0 % build" is displayed.
Related branches
lp:~gunchleoc/widelands/bug-1278583
- SirVer: Approve
-
Diff: 27 lines (+4/-2)2 files modifiedsrc/logic/constructionsite.cc (+1/-1)
src/logic/immovable.cc (+3/-1)
Changed in widelands: | |
assignee: | nobody → GunChleoc (gunchleoc) |
Changed in widelands: | |
status: | Confirmed → In Progress |
Changed in widelands: | |
status: | In Progress → Fix Committed |
Changed in widelands: | |
milestone: | none → build19-rc1 |
Changed in widelands: | |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks for taking your time to report this issue.
It does indeed seem like this string is not translatable. I grepped for it in the source, and found it in two places. (I wonder if it might be an idea to split out "% built" from the longer string and make that part only translatable. Reduce the risk of a type breaking the tags or formating)
$ grep -rin "% built" . immovable. cc:545: (boost: :format( "<font color=%1$s>%2$i%% built</font>") % UI_FONT_ CLR_DARK_ HEX % percent).str(); constructionsit e.cc:91: (boost: :format( "<font color=%1$s>%2$i%% built</font>") % UI_FONT_ CLR_DARK_ HEX % percent).str();
./logic/
./logic/
PS. Please mention which language you are playing the game in another time, this makes it easier to search in the translated strings to see whether it is a general issue or only affecting a single language.