Horizon hangs when double deleting instance

[Erasmo Isotton]

Steps to reproduce:

1. In Horizon, launch an instance;
2. After the launching is completed, terminate the instance;
3. While the instance is being deleted, a "Terminate Instance" button appears within the row for the instance being terminated;
4. Press the Terminate Instance button while the instance was not terminated yet;
5. In the Terminate Instance confirmation dialog, wait until the instance has been deleted (as it disappears from the list in the grayed out background page);
6. Press the Terminate Instance button in the confirmation dialog;
7. The UI hangs indefinitely, showing a "Working" status.

Refreshing the browser session seems to clear the problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/72469

[David Lapsley (dlapsley)]

Hi Erasmo: I was able to replicate and took a crack at fixing the bug. I just tested and submitted a fix. Let me know what you think.

Cheers, David.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72469
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ccc71b20909db3fd5a6301a4ecf3aaea703f5bf2
Submitter: Jenkins
Branch: master

commit ccc71b20909db3fd5a6301a4ecf3aaea703f5bf2
Author: David Lapsley <email address hidden>
Date: Mon Feb 10 12:01:17 2014 -0800

    Fixes instance double delete via row_action

    Currently when an instance is terminated, via the project/instances view,
    a "Terminate Instnace" button appears in the row_action column.

    This is due to a the TerminateInstance class's allowed() method always
    returning true.

    By putting logic in this method to only allow the terminate row_action
    when an instance is *not* being deleted, we prevent the double delete from
    occurring via row_action.

    Change-Id: I23e759036c8f6c35331243717853c8a5e269fa75
    Closes-Bug: 1278487