root-enabled instance when restored reports as root-disabled box

Bug #1277745 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Sushil Kumar

Bug Description

If a root_enable instance's backup is restored, though the resulting instance would come up with root enabled, but it is not reported to service database and root-show api shows it root-disabled.

https://review.openstack.org/#/c/59410 has introduced a bug for create instance through restore-path.

https://review.openstack.org/#/c/59410/10/trove/guestagent/datastore/mysql/manager.py shows report_root_enabled was there for two cases
 a. New instance with a root_password
 b. If it was enable_root_on_restore
but
https://review.openstack.org/#/c/59410/10/trove/taskmanager/models.py has report_root_enabled only for only one case(New instance with a root_password), it missed for restore-path

Revision history for this message
Sushil Kumar (sushil-kumar2) wrote :

Steps to reproduce
1. Create an instance
2. Enable root
3. Take a backup of instance create in step 1.
4. Create an instance restoring the backup taken in step 3.
5. Try root-show on instance created in step 4.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/72025

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Changed in trove:
importance: Undecided → Medium
milestone: none → juno-1
Changed in trove:
milestone: juno-1 → juno-2
Changed in trove:
milestone: juno-2 → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/72025
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=b0b92bf171b3f3c1c58beeb8434753380a30c2cf
Submitter: Jenkins
Branch: master

commit b0b92bf171b3f3c1c58beeb8434753380a30c2cf
Author: SushilKM <email address hidden>
Date: Wed May 28 15:03:45 2014 +0000

    Reports enabled-root for restored instance

    Reasons:
    - This condition got missed in one of the earlier patchsets.
    - When a root-enabled instance's backup is restored, it does not
      reports to service database that root was enabled for
      restored instance.

    Changes:
    - report_root method added in conductor.
    - Reports, if root is enabled for restored instance, through conductor.

    Change-Id: I186398e6651421cecb7169e4eec1d6a8a166ee97
    Closes-Bug: #1277745

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.