LONPRESSLATCHING and POWERWINDOW is not working from midi

[Daniel Schürmann]

The code inside Mixxx assumes that the Buttons on the Midi device will send
MIDI_NOTE_ON and
MIDI_NOTE_OFF

At Least the RMX2 controller sends allays MIDI_NOTE_ON

Debug [Controller]: "MIDI status 0x90 (ch 1, opcode 0x9), ctrl 0x23, val 0x7F"
Debug [Controller]: "MIDI status 0x90 (ch 1, opcode 0x9), ctrl 0x23, val 0x00"

Inside the code there is a comment:
// looking for NOTE_ON doesn't seem to work...
This and the other !value toggle workarounds are looking like all controllers are sending a good value and we can ignore the MIDI_NOTE.

If this is not the case we have to make it configurable.

[Daniel Schürmann (daschuer)]

Ok I was wrong. From the log of a AmericanAudio VMS4 in Bug #1277391 we see:

Debug [Controller]: "MIDI status 0x90 (ch 1, opcode 0x9), ctrl 0x0D, val 0x7F"
Debug [Controller]: "MIDI status 0x80 (ch 1, opcode 0x8), ctrl 0x0D, val 0x40"

[Daniel Schürmann (daschuer)]

fixed in https://github.com/mixxxdj/mixxx/pull/175

[RJ Skerry-Ryan (rryan)]

Always sending note-on messages means the MIDI controller has broken or stupid firmware :) -- I'm against hacking Mixxx for this. We used to do this with MIDI Option flags but adding more and more of those became unmaintainable. This should be solved with MIDI script.

[RJ Skerry-Ryan (rryan)]

Hm, I read the linked article: http://de.wikipedia.org/wiki/Musical_Instrument_Digital_Interface and some other documents and it does seem a note-on with velocity of 0 could be interpreted as a note-off. Sorry about that!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7297