Quotas change incorrectly when a resizing instance is deleted

[Hans Lindgren]

When deleting a resizing instance that has not yet finished resizing, quotas should be adjusted for the old flavor type. Instead it incorrectly use values from the new flavor.

This was originally reported and fixed in bug 1099729 but has since resurfaced with the move to objects (commit dce64683291ba2cdb5e6617e01ccc2909254acb4). This was made possible by a prior change (commit a56f0b33069b919ebb24c4afdcc6b6c31592c98e) that accidentally removed the test put in place to guard against this error ever happening again.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/71847

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/71847
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c70749b9c8d9575ba28b2c012615d6bae146ccc3
Submitter: Jenkins
Branch: master

commit c70749b9c8d9575ba28b2c012615d6bae146ccc3
Author: Hans Lindgren <email address hidden>
Date: Fri Feb 7 10:33:55 2014 +0100

    Fix wrong quota calculation when deleting a resizing instance

    When deleting a resizing instance that has not yet finished resizing,
    quotas should be adjusted for the old flavor type. Instead it
    incorrectly use values from the new flavor.

    This was previously fixed in bug 1099729, but has since resurfaced
    with the change to use objects in delete methods.

    Change-Id: I9bc68abc0d86784c642483dd0cc46c6b9c6a0c69
    Closes-Bug: #1277422