"trove help root-show" does not says correct help message as per behavior of API

Bug #1277308 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-troveclient
Fix Released
Low
Sushil Kumar

Bug Description

"trove help root-show" does not says correct help message as per behavior of API

What API checks is if root was ever enabled for a instance, which means, if we enable root and then go in database manually tweak database for our requirement and then we go on to do the cleanup by manually removing the root user.

root-show API would still say that si_root_enabled = True, which means its checking the historic enables also.

So, there is a need to update the help message of root-show api which crrently says "Gets root enabled status for a instance." which suggests as if it would check if root user is currently existing in the guest database.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/71711

Changed in python-troveclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Changed in python-troveclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-troveclient (master)

Reviewed: https://review.openstack.org/71711
Committed: https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=8a632221320b91759b7b6018ec6097d4cc404701
Submitter: Jenkins
Branch: master

commit 8a632221320b91759b7b6018ec6097d4cc404701
Author: Sushil Kumar <email address hidden>
Date: Fri Feb 7 01:48:23 2014 +0000

    Updates root-enable & root-show help messages

    Reasons:
    - Help message for root-enable does not gives complete information, it
      misses that API also resets root, on existence.
    - Current help message for root-show makes it feel like current status
      of root user is fetched, but instead we are also returning True for
      historical root access enabled.

    Changes:
    - Updated the root-enable and root-show API help message.
    - Updated README for updated help messages.

    Change-Id: Ide7c331bdfe5437e6966f6cd4f331cb3b22d0c3f
    Closes-Bug: #1277308

Changed in python-troveclient:
status: In Progress → Fix Committed
Changed in python-troveclient:
milestone: none → 1.2.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.