Stack adoption can be stuck

[Thomas Herve]

I tried to adopt a stack with a random stack_adopt data, and got this traceback:

  File "/opt/stack/heat/heat/engine/scheduler.py", line 331, in __call__
    r.start()
  File "/opt/stack/heat/heat/engine/scheduler.py", line 159, in start
    result = self._task(*self._args, **self._kwargs)
  File "/opt/stack/heat/heat/engine/parser.py", line 431, in resource_action
    return handle(**handle_kwargs(r))
  File "/opt/stack/heat/heat/engine/parser.py", line 405, in _adopt_kwargs
    if not data or not data.get('resources'):
AttributeError: 'unicode' object has no attribute 'get'

Unfortunately the stack stayed in ADOPT_IN_PROGRESS and I didn't get any feedback outside of the logs.

[Thomas Herve (therve)]

Hum apparently adopt may not work at all.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/71553

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/71553
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b7fa93a03cc057b8a4090fbfd9cb23f95aef804f
Submitter: Jenkins
Branch: master

commit b7fa93a03cc057b8a4090fbfd9cb23f95aef804f
Author: Thomas Herve <email address hidden>
Date: Thu Feb 6 15:59:15 2014 +0100

    Parse stack_adopt_data

    The patch parses the argument passed to stack_create, and validates that
    it's a dictionary, preventing engine failures in the future.

    Closes-Bug: #1277106
    Change-Id: I88cbf933ddac5776d5ffc0151bc7a0b296048777