Role and Name of the node is not discarded after deleting environment if node was in discarded state

[Andrey Sledzinskiy]

Bug is reproduced on fuel-4.1-91-2014-02-05_01-17-30.iso

Steps:
1. Create new environment with all default values
2. Open Nodes tab
3. Click Add nodes
4. Assign Compute role to any Node and change Node name to 'Test compute node'
5. Click Apply Changes – changes are saved and page with added nodes is present
6. Click 'discard addition' for added Node
7. Delete Environment
8. Wait until all nodes are discovered again
9. Create new environment
10. Open nodes tab and click Add nodes
Expected – all nodes are with 'untitled' name and 'unallocated' role
Actual – discarded node is with Compute role and 'Test compute node' name (see attach DiscardedNodeResetBug.png)

[Evgeniy L (rustyrobot)]

I think we should change unassignment logic, as I know Alexander is working on this task https://bugs.launchpad.net/fuel/+bug/1265036 and maybe it can be solved as part of his task.

But REST api will be changed, for assignment and assignment will be implemented separate handlers.
https://bugs.launchpad.net/fuel/+bug/1265036/comments/2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/74000

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/74000
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=b00091975864366b534e06628730bfbfb7aaaa17
Submitter: Jenkins
Branch: master

commit b00091975864366b534e06628730bfbfb7aaaa17
Author: Evgeniy L <email address hidden>
Date: Mon Feb 17 15:35:29 2014 +0400

    Fix discard changes to remove node from a cluster

    * fix js, use 'cluster_id' instead of 'cluster'
    * reset cluster name to default when user
      removes node from cluster

    Closes-bug: #1277081
    Change-Id: I8d0794f398ab978d4062e02e731cc7a2711cb4a6

[Andrey Sledzinskiy (asledzinskiy)]

Verified on ISO #160

Revision: 0b9ba969d1cff3d9de78d9feb4fb0f4539fc74de
origin/master