Swift-storage charm doesn't add disks to fstab
Bug #1276911 reported by
Brad Marshall
This bug affects 5 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
swift-storage (Juju Charms Collection) |
Fix Released
|
Medium
|
Jorge Niedbalski |
Bug Description
The latest version of swift-storage - I tested using r24 - doesn't setup fstab entries for any of the block devices. This means once the swift-storage nodes reboot, the filesystems don't mount.
The code in setup_storage() in swift_storage_
if persist:
# TODO: update fstab
pass
Either a fix needs to be made to charmhelpers, or a work around put in place in swift-storage charm to not rely on unfinished code.
Please let me know if you need any further information.
Related branches
lp:~niedbalski/charm-helpers/add-fstab-support
- Matt Bruzek: Approve
-
Diff: 345 lines (+263/-10)5 files modifiedcharmhelpers/core/fstab.py (+114/-0)
charmhelpers/core/host.py (+20/-6)
charmhelpers/fetch/bzrurl.py (+2/-1)
tests/core/test_fstab.py (+86/-0)
tests/core/test_host.py (+41/-3)
lp:~niedbalski/charms/precise/swift-storage/add-fstab-persist
- OpenStack Charmers: Pending requested
-
Diff: 198 lines (+136/-7)3 files modifiedhooks/charmhelpers/core/fstab.py (+114/-0)
hooks/charmhelpers/core/host.py (+20/-6)
hooks/swift_storage_utils.py (+2/-1)
- OpenStack Charmers: Pending requested
-
Diff: 179 lines (+117/-7)3 files modifiedhooks/charmhelpers/core/fstab.py (+95/-0)
hooks/charmhelpers/core/host.py (+20/-6)
hooks/swift_storage_utils.py (+2/-1)
lp:~james-page/charms/trusty/swift-storage/fstab-persist
- Liam Young (community): Approve
- Chuck Short (community): Needs Information
-
Diff: 1215 lines (+84/-705)15 files modifiedcharm-helpers.yaml (+1/-1)
hooks/charmhelpers/contrib/hahelpers/cluster.py (+2/-12)
hooks/charmhelpers/contrib/network/ip.py (+10/-97)
hooks/charmhelpers/contrib/openstack/amulet/deployment.py (+0/-61)
hooks/charmhelpers/contrib/openstack/amulet/utils.py (+0/-275)
hooks/charmhelpers/contrib/openstack/context.py (+16/-84)
hooks/charmhelpers/contrib/openstack/ip.py (+0/-75)
hooks/charmhelpers/contrib/openstack/neutron.py (+0/-14)
hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg (+1/-6)
hooks/charmhelpers/contrib/openstack/templating.py (+23/-22)
hooks/charmhelpers/contrib/openstack/utils.py (+3/-11)
hooks/charmhelpers/contrib/storage/linux/ceph.py (+1/-1)
hooks/charmhelpers/core/hookenv.py (+4/-5)
hooks/charmhelpers/core/host.py (+6/-8)
hooks/charmhelpers/fetch/__init__.py (+17/-33)
lp:~niedbalski/charms/trusty/swift-storage/mr-corrected-1276911
- Chris Glass (community): Approve
-
Diff: 26 lines (+3/-2)2 files modifiedhooks/swift_storage_utils.py (+1/-1)
unit_tests/test_swift_storage_utils.py (+2/-1)
Changed in swift-storage (Juju Charms Collection): | |
assignee: | nobody → charmers (charmers) |
Changed in swift-storage (Juju Charms Collection): | |
status: | New → Confirmed |
tags: | added: se-demolab |
tags: | added: landscape |
Changed in swift-storage (Juju Charms Collection): | |
status: | Triaged → In Progress |
Changed in swift-storage (Juju Charms Collection): | |
assignee: | charmers (charmers) → Jorge Niedbalski (niedbalski) |
Changed in swift-storage (Juju Charms Collection): | |
status: | Fix Released → Fix Committed |
tags: | added: cloud-installer |
Changed in swift-storage (Juju Charms Collection): | |
status: | New → In Progress |
Changed in swift-storage (Juju Charms Collection): | |
status: | In Progress → Fix Committed |
tags: | added: openstack |
tags: | added: cts |
Changed in swift-storage (Juju Charms Collection): | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've tried going back to revision 18 and this bug is still there, no fstab entry and so the filesystems don't mount on reboot.