simple_tenant_usage extension should not rely on looking up flavors

[Dan Smith]

The simple_tenant_usage extension gets the flavor data from the instance and then looks up the flavor from the database to return usage information. Since we now store all of the flavor data in the instance itself, we should use that information instead of what the flavor currently says is right. This both (a) makes it more accurate and (b) avoids us failing to return usage info if a flavor disappears.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76230

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76230
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c9a020f121a85ff88b890e964dc8c1f6d0ff5843
Submitter: Jenkins
Branch: master

commit c9a020f121a85ff88b890e964dc8c1f6d0ff5843
Author: jichenjc <email address hidden>
Date: Tue Feb 25 20:00:09 2014 +0800

    Use instance data instead of flavor in simple_tenant_usage extension

    The simple_tenant_usage extension gets the flavor data from the instance
    and then looks up the flavor from the database to return usage information.
    Since we now store all of the flavor data in the instance itself,
    we should use that information instead of what the flavor currently
    says is right. This both (a) makes it more accurate and (b)
    avoids us failing to return usage info if a flavor disappears.

    Change-Id: I1472d78e8e920013a1db5c76e04715fa04b696c2
    Closes-Bug: #1276731