failure to poll for server creation treated as failure to create

[Robert Collins]

I've a nova server that is flaking from time to time (long story, don't ask :)) - but its normal, if rare, to have nova give a 500 error.

After spawning a server though, if heat encounters an error - e.g.
| NovaCompute1 | 7fb1dc6e-eb5d-4593-b08b-07586877011f | ClientException: The server has either erred or is incapable of performing the requested operation. (HTTP 500) (Request-ID: req-1ce55e04-e99b-479f-a418-9790df59e647) | CREATE_FAILED | 2014-02-05T10:15:04Z o|

it treats that as a failed creation rather than a failure to obtain information, which is all it is.

[Clint Byrum (clint-fewbar)]

This affects TripleO quite a bit. 500 is "their problem" but it is not an indication of a permanent error, so I do think we should keep polling on 500's.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/71644

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/71644
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1b63926d76afb167186d9049cb9ff6591350109d
Submitter: Jenkins
Branch: master

commit 1b63926d76afb167186d9049cb9ff6591350109d
Author: Jason Dunsmore <email address hidden>
Date: Thu Feb 6 12:57:09 2014 -0600

    Handle API 500 response in OS::Nova::Server

    novaclient raises a ClientException when a 500 response code is returned
    from the Nova API. Previously, this would cause the stack action to
    fail. Log a warning instead.

    Closes-Bug: #1276517
    Change-Id: I8f00d476c8d7166aca74fdcd3e0f2621c00d9802