Changing a Port's MAC address doesn't take a lock on the Node

Bug #1276393 reported by aeva black
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Yuriy Zveryanskyy

Bug Description

Changing Port data should be handled the same way as changing Node data -- it should require a TaskManager lock (of the related Node), particularly if changing the Port's address field. This may also need to trigger specific driver actions, such as updating Neutron.

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → High
aeva black (tenbrae)
Changed in ironic:
milestone: none → icehouse-3
Michael Davies (mrda)
Changed in ironic:
assignee: nobody → Michael Davies (mrda)
Michael Davies (mrda)
Changed in ironic:
assignee: Michael Davies (mrda) → nobody
Changed in ironic:
assignee: nobody → Digambar (digambarpatil15)
Revision history for this message
Rohan (kanaderohan) wrote :

Hey Digambar, are you still working on this, any updates?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77623

Changed in ironic:
assignee: Digambar (digambarpatil15) → Yuriy Zveryanskyy (yzveryanskyy)
status: Triaged → In Progress
Revision history for this message
Digambar (digambarpatil15) wrote :

Guys this bug is fixed but not able to commit the code due to gerrit issues.

aeva black (tenbrae)
Changed in ironic:
milestone: icehouse-3 → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/77623
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d4f77b66ea766aa17f7cdbf8a4bcc6188998e33b
Submitter: Jenkins
Branch: master

commit d4f77b66ea766aa17f7cdbf8a4bcc6188998e33b
Author: Yuriy Zveryanskyy <email address hidden>
Date: Mon Mar 3 10:29:18 2014 +0200

    Add TaskManager lock on change port data

    Updating port data may require driver actions on the related node
    (if address changed for example). New method 'update_port' added
    to conductor manager and rpcapi.

    Partial-Bug: #1276393
    Related-Bug: #1236714
    Change-Id: I1f817a8b3c80630f40fd36c82e533d5358225150

aeva black (tenbrae)
Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.