We have the following code in the spawn() method in vmops.py:
def spawn(...):
...
def _execute_create_vm():
vm_create_task = self._session._call_method(...)
self._session._wait_for_task(instance['uuid'], vm_create_task)
_execute_create_vm()
vm_ref = vm_util.get_vm_ref_from_name(self._session, instance_name)
...
get_vm_ref_from_name() is making remote call which is redundant because we can obtain a reference to the created VM from the CreateVM task itself. From the the vSphere documentation:
"This method returns a Task object with which to monitor the operation. The info.result property in the Task contains the newly created VirtualMachine upon success."
We should fix _execute_create_vm() to get the VM from the task and return it.
Fix proposed to branch: master
Review: https:/