q-agent-cleanup.py and special characters in password

Bug #1275655 reported by Andrey Kirilochkin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Matthew Mosesohn

Bug Description

I plan to use pass something like this: F11T%)w123Is123Zp3%c5g-D for admin. And changing it in Horizon.
After i change default pass in /root/openrc: F11T\%\)w123Is123Zp3\%c5g\-D.

then
{code}
. openrc
nova list
+--------------------------------------+--------------------+---------+------------+-------------+------------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+--------------------+---------+------------+-------------+------------------------------------+
| 353cf607-6dc4-41dc-9193-818f4919e9c5 | my2_test_floating | ACTIVE | None | Running | net04=192.168.111.16, |
|e68829d4-fd25-49d5-9f1d-27a1815ccd14 | nginx ubuntu 12.04 | ACTIVE | None | Running | net04=192.168.111.8 |
| ef021daa-316a-49c3-b6dc-141bac571ac5 | ubuntu deyan test | ACTIVE | None | Running | net04=192.168.111.10| +--------------------------------------+--------------------+---------+------------+-------------+------------------------------------+
{code}
nova is working but /usr/bin/q-agent-cleanup.py can't understand this pass due to special charachters, i think:
{code}
2014-02-02 08:55:26,827 - INFO - Started: /usr/bin/q-agent-cleanup.py --agent=dhcp --reschedule --remove-dead
>>> Keystone error:
The request you have made requires authentication.
{code}

Revision history for this message
Andrey Danin (gcon-monolake) wrote :
tags: added: library
tags: removed: characters openrc q-agent-cleanup.py special
tags: added: low-hanging-fruit
Changed in fuel:
importance: Undecided → Medium
status: New → Confirmed
milestone: none → 4.1
Changed in fuel:
status: Confirmed → Triaged
milestone: 4.1 → 5.0
Changed in fuel:
assignee: nobody → Matthew Mosesohn (raytrac3r)
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

password is escaped in openrc by purpose
otherwise ". openrc" command will be broken.
Looks like nova is fine with password in openrc file and q-agent-cleanup.py is broken

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76860

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/76860
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=028832a769edcc797d65a3fe0675f15037c7a2a7
Submitter: Jenkins
Branch: master

commit 028832a769edcc797d65a3fe0675f15037c7a2a7
Author: Matthew Mosesohn <email address hidden>
Date: Thu Feb 27 17:16:40 2014 +0400

    q-agent-cleanup escape character handling

    /root/openrc should contain escaped characters for
    certain symbols, but are stripped when sourcing
    this file in shell scripts. p-agent-cleanup.py
    should treat user credentials as escaped strings
    and not literal escape characters.

    Closes-Bug: #1275655

    Change-Id: Ia9534ef93508813b2a8cdc7368cf6f121ea40fe7

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.