S3 middleware uses httplib

Bug #1275598 reported by Jamie Lennox
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
High
Jamie Lennox

Bug Description

We previously converted keystoneclient to use the requests library due at least partially to the fact that it doesn't validate SSL certificates.

When we moved S3 middleware from keystone we moved it directly and it still uses httplib so we need to make it use requests.

Revision history for this message
Chmouel Boudjnah (chmouel) wrote :

would not mind to take that, let me know if you were planning to assign this to you Jamie.

Changed in python-keystoneclient:
assignee: nobody → Chmouel Boudjnah (chmouel)
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Jamie Lennox (jamielennox) wrote :

It appears that automatic bug linking no longer works. Sorry Chmouel i had reviews up for that one already.

https://review.openstack.org/#/c/70646/

and

https://review.openstack.org/#/c/70647/

Changed in python-keystoneclient:
assignee: Chmouel Boudjnah (chmouel) → Jamie Lennox (jamielennox)
status: Triaged → In Progress
Revision history for this message
Chmouel Boudjnah (chmouel) wrote :

no worries.

Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.5.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/70646
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=773682523563ec0fb884a232e08442e8b6291343
Submitter: Jenkins
Branch: master

commit 773682523563ec0fb884a232e08442e8b6291343
Author: Jamie Lennox <email address hidden>
Date: Mon Feb 3 13:07:36 2014 +1000

    Use HTTPretty in S3 test code

    Remove the httplib specific mocks that are used within the S3
    middleware. This won't work when we convert S3 middleware to use the
    requests library.

    Change-Id: Iee5f3089286c980bef3a19dc9d5068399946e217
    Related-Bug: #1275598

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/70647
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=9fda5add290365809e847a2a9c4dba47c1e94a4f
Submitter: Jenkins
Branch: master

commit 9fda5add290365809e847a2a9c4dba47c1e94a4f
Author: Jamie Lennox <email address hidden>
Date: Mon Feb 3 13:14:53 2014 +1000

    Use requests library in S3 middleware

    Convert the S3 token middleware to use the requests library. It does not
    validate certificates as part of this patch to keep new functionality
    isolated.

    Change-Id: I0f26c80a969b919de80410af0a80920bd8493191
    Closes-Bug: #1275598

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.