bad rule interpretation

Bug #1275032 reported by Hans Ginzel
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Gufw
Opinion
Undecided
Unassigned
gui-ufw (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

It seems that ufw from rule
[Rule1]
ufw_rule = 22/tcp ALLOW IN Anywhere
description = SSH
command = ufw allow in 22/tcp
policy = allow
direction = in
protocol =
from_ip = 10.0.0.0/28
from_port =
to_ip =
to_port = 22/tcp
iface =
logging =

produces

Appending new Gufw rule: ufw allow in from 10.0.0.0/28 22/tcp > ERROR: Wrong number of arguments

instead of

ufw allow in from 10.0.0.0/28 port 22 proto tcp
.

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: gufw 13.10.2-0ubuntu1
ProcVersionSignature: Ubuntu 3.11.0-15.8-lowlatency 3.11.10
Uname: Linux 3.11.0-15-lowlatency i686
ApportVersion: 2.12.5-0ubuntu2.2
Architecture: i386
Date: Fri Jan 31 18:46:38 2014
EcryptfsInUse: Yes
MarkForUpload: True
PackageArchitecture: all
SourcePackage: gui-ufw
UpgradeStatus: Upgraded to saucy on 2013-10-24 (99 days ago)

Revision history for this message
Hans Ginzel (hans-matfyz) wrote :
Revision history for this message
costales (costales) wrote :

I'll review this :) There're dragons in that point of code :S hehehe

Changed in gui-ufw:
status: New → In Progress
Revision history for this message
Hans Ginzel (hans-matfyz) wrote :

I hope I found one of the dragon. Be inspired by attached patch.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "corrected ufw command" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
costales (costales) wrote :

Uhm... Could you try the last version please? :) (It works in Ubuntu 13.10):
sudo apt-get purge gufw ; sudo rm -r /etc/gufw ; wget https://launchpad.net/gui-ufw/gufw-14.04/14.04/+download/gufw_14.04.1.deb ; sudo dpkg -i gufw_14.04.1.deb

As you can see in the attachment screenshots:
 1. User enters port 22 and he can set the protocol in the combobox Protocol.
 2. User enters port 22/tcp and some fields will be disabled (as IP).

As I told you, there are dragons there :P I just don't remember the case, but ufw was not allowing a specific command and then I preferred to guarantee the user's entry enabling/disabling fields and ensure that any command will be right.

The current Gufw is a LTS, then I'm so sorry, but I'll not change this behaviour now :S But I'll think in your proposal either! ;)

Changed in gui-ufw (Ubuntu):
status: New → Invalid
Changed in gui-ufw:
status: In Progress → Triaged
costales (costales)
Changed in gui-ufw:
status: Triaged → Opinion
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.