Contract - recurring invoice not working if YEARS is selected

[Daniel Dico (oerp.ca)]

Hello,

Re: trunk (9089) and saas-2(9111)

If you setup a contract with recurring invoices and select to repeat on a yearly basis it will not work. Will repeat monthly instead or yearly. Looking at code we observe that "yearly" option in recurring_rule_type is not handled.

            if contract.recurring_rule_type == 'daily':
                new_date = next_date+relativedelta(days=+interval)
            elif contract.recurring_rule_type == 'weekly':
                new_date = next_date+relativedelta(weeks=+interval)
            else:
                new_date = next_date+relativedelta(months=+interval)

I suggest this change:

+++ account_analytic_analysis/account_analytic_analysis.py 2014-01-31 15:49:05 +0000
@@ -721,8 +721,10 @@
                 new_date = next_date+relativedelta(days=+interval)
             elif contract.recurring_rule_type == 'weekly':
                 new_date = next_date+relativedelta(weeks=+interval)
- else:
+ elif contract.recurring_rule_type == 'monthly':
                 new_date = next_date+relativedelta(months=+interval)
+ elif contract.recurring_rule_type == 'yearly':
+ new_date = next_date+relativedelta(years=+interval)
             self.write(cr, uid, [contract.id], {'recurring_next_date': new_date.strftime('%Y-%m-%d')}, context=context)
         return True

Please let me know if you need more information

Thank you

[Daniel Dico (oerp.ca) (oerp)]

I see it was fixed May 19, 2014 in trunk:
https://github.com/odoo/odoo/commit/4dbaa116ee2b8f7986f17c7e12fb2afb8f86435d