Settings the availability zone deletes all attached metadata

[Thomas Bechtold]

I'm using latest git with devstack on Ubuntu 12.04.

When I update the availability zone the attached metadata gets deleted. Steps to reproduce the problem:

 1) nova aggregate-create testagg #assuming that this creates a new metadata entry with the Id 26
 2) nova aggregate-set-metadata 26 x=y
 3) nova aggregate-update 26 testagg zone1

Now the availability zone is set, but the x=y metadata is lost.

[John Garbutt (johngarbutt)]

I think that is as expected, it updates all the metadata to that supplied, however, its a bit confusing.

[Joe Gordon (jogo)]

This is working as expected.

We can update this behavior in the V3 API or make the python-novaclient more intelligent to handle this

[Santiago Baldassin (santiago-b-baldassin)]

hi guys, even when this is working as expected I don't think it's working ok. We have two api calls to do the same thing both set-metadata and update will manipulate the aggregate metadata.

Adding/updating availability zone ends up setting metadata then we should use update_aggregate_metadata instead of update_aggregate. I guess we are just replacing the existing metadata to enforce the uniqueness of availability zone for an aggregate.

Set metadata for aggregates will be added to the dashboard so I think before exposing the functionality to the end users we should figure this out

[melanie witt (melwitt)]

Novaclient could be updated to not pass on an empty metadata update (or pass the same/current metadata) if the user omits the argument on the command line.

[Santiago Baldassin (santiago-b-baldassin)]

Won't be fixed in nova as it will introduce backward incompatibility. See review: https://review.openstack.org/#/c/81356/

[Santiago Baldassin (santiago-b-baldassin)]

Please disregard my previous comment. Got confused with another bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/84202

[Santiago Baldassin (santiago-b-baldassin)]

Fixed in nova. No need to fix in python-nova-cllient

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84202
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=328beb0433c04a0888d38cbc2927248fdd963318
Submitter: Jenkins
Branch: master

commit 328beb0433c04a0888d38cbc2927248fdd963318
Author: Santiago Baldassin <email address hidden>
Date: Mon Mar 31 14:12:28 2014 -0300

    Do not replace the aggregate metadata when updating az

    When the aggregate availability zone is updated, the
    existing metadata should not be replaced

    Change-Id: Ife856af9e7dca836ebe8a1ec050effaad421e17d
    Closes-Bug: #1274924

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/99453

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/99454

[OpenStack Infra (hudson-openstack)]

Change abandoned by Santiago Baldassin (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/99453

[OpenStack Infra (hudson-openstack)]

Change abandoned by Santiago Baldassin (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/99454

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/133643

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Geng (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/133643