Make "Enhance" a toggle button

Bug #1274810 reported by Danielle Foré
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Photos
Fix Released
Wishlist
meese

Bug Description

Since it seems you can only "enhance" a photo once, perhaps this should be a toggle where we undo the enhancing if it's clicked a second time

Related branches

Revision history for this message
Jim Nelson (yorba-jim) wrote :

The Enhance operation merely adjusts the photo's color settings using heuristics. That is, there's nothing in the database today that says "these color settings were from Enhance". The user could, for example, press Enhance and then manually adjust the colors and there's no way to know (without running the Enhance algorithm again and comparing results, which is time-consuming). In this state, if the user presses Enhance again, Shotwell will reset the colors to its own enhance algorithm's results.

One way to achieve this ticket's goal would be to store the color adjustments and include a new flag in the photo's transformation settings which says, in effect, "these color adjustments are from Enhance". If the user manually adjusts the colors or resets to original, the flag is reset. The Enhance button would work its magic only if the flag is clear, otherwise it resets to original colors.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Yeah Jim that makes sense for the behind-the-scenes. From the UI point of view, when the flag is set, the button would appear "pressed" and when it's cleared, the button would return to being de-pressed.

Changed in pantheon-photos:
status: New → Confirmed
meese (meese)
Changed in pantheon-photos:
assignee: nobody → meese (madelynn-r-may)
meese (meese)
Changed in pantheon-photos:
status: Confirmed → Fix Committed
Changed in pantheon-photos:
milestone: none → freya-beta2
Changed in pantheon-photos:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.