Make "Enhance" a toggle button
Bug #1274810 reported by
Danielle Foré
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Photos |
Fix Released
|
Wishlist
|
meese |
Bug Description
Since it seems you can only "enhance" a photo once, perhaps this should be a toggle where we undo the enhancing if it's clicked a second time
Related branches
lp:~meese/pantheon-photos/fix-1274810
- Erasmo Marín: Approve
- Danielle Foré: Approve (ux)
-
Diff: 890 lines (+374/-45)11 files modifiedsrc/CollectionPage.vala (+86/-13)
src/CommandManager.vala (+1/-1)
src/Commands.vala (+38/-2)
src/Photo.vala (+117/-6)
src/PhotoPage.vala (+61/-13)
src/Resources.vala (+4/-1)
src/db/DatabaseTable.vala (+1/-1)
src/db/Db.vala (+18/-0)
src/db/PhotoTable.vala (+47/-6)
src/main.vala (+1/-1)
ui/collection.ui (+0/-1)
Changed in pantheon-photos: | |
assignee: | nobody → meese (madelynn-r-may) |
Changed in pantheon-photos: | |
status: | Confirmed → Fix Committed |
Changed in pantheon-photos: | |
milestone: | none → freya-beta2 |
Changed in pantheon-photos: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The Enhance operation merely adjusts the photo's color settings using heuristics. That is, there's nothing in the database today that says "these color settings were from Enhance". The user could, for example, press Enhance and then manually adjust the colors and there's no way to know (without running the Enhance algorithm again and comparing results, which is time-consuming). In this state, if the user presses Enhance again, Shotwell will reset the colors to its own enhance algorithm's results.
One way to achieve this ticket's goal would be to store the color adjustments and include a new flag in the photo's transformation settings which says, in effect, "these color adjustments are from Enhance". If the user manually adjusts the colors or resets to original, the flag is reset. The Enhance button would work its magic only if the flag is clear, otherwise it resets to original colors.