HashRing does not handle invalid inputs

Bug #1274762 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
aeva black

Bug Description

The HashRing class will fail with

  TypeError: must be string or buffer, not None

if passing None to __init__ or to get_hosts.

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Devananda van der Veen (devananda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/70267

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/70267
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=469daf557416c725c9ac32f469b11dcaf3fa6b5a
Submitter: Jenkins
Branch: master

commit 469daf557416c725c9ac32f469b11dcaf3fa6b5a
Author: Devananda van der Veen <email address hidden>
Date: Thu Jan 30 15:57:03 2014 -0800

    Improve handling of invalid input in HashRing class

    HashRing __init__ and get_hosts shouldn't be passed None,
    but if they are, an appropriate error should be raised.

    Change-Id: I139e7410c43bf4ac0f3357797ad767fde9455e36
    Closes-bug: #1274762

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.