_test_postgresql_opportunistically calls get_mysql_connection_info

Bug #1274718 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Matt Riedemann

Bug Description

Not sure if this is intentional or an oversight, but nova.tests.db.test_migrations.BaseWalkMigrationTestCase._test_postgresql_opportunistically calls get_mysql_connection_info even though there is a get_pgsql_connection_info method that is slightly different and used elsewhere.

Obviously not breaking anything, but should probably be cleaned up.

Matt Riedemann (mriedem)
tags: added: low-hanging-fruit
Michael Still (mikal)
Changed in nova:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Matt Riedemann (mriedem) wrote :
Changed in nova:
assignee: nobody → Matt Riedemann (mriedem)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/70532
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e6ac12041ebe85fe9d46ab9346ae0bc9ef0a3599
Submitter: Jenkins
Branch: master

commit e6ac12041ebe85fe9d46ab9346ae0bc9ef0a3599
Author: Matt Riedemann <email address hidden>
Date: Sat Feb 1 06:03:00 2014 -0800

    Call get_pgsql_connection_info from _test_postgresql_opportunistically

    The _test_postgresql_opportunistically method was calling the method to
    parse the mysql connection URL which is wrong when there is one
    specifically for postgresql, so call the right method.

    This wasn't causing issues obviously but is something that needs to be
    cleaned up regardless.

    Closes-Bug: #1274718

    Change-Id: Ic572e612c7ce31d854dc7258aa9c8b89a197260e

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.