update.py fails silently if module is not found

Bug #1274647 reported by Chris Buccella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Undecided
Chris Buccella

Bug Description

Example:

$ python update.py --base cinder --dest-dir ../cinder --modules middleware/base.py
Copying middleware/base.py under the cinder module in ../cinder
$

Clearly, appending the ".py" is incorrect, but there is no message printed informing the user that the copy failed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/70191

Changed in oslo:
assignee: nobody → ChrisBuccella (chris-buccella)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/70191
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=42ffde1a3df00651cf586a96a06b60e471ad4b41
Submitter: Jenkins
Branch: master

commit 42ffde1a3df00651cf586a96a06b60e471ad4b41
Author: Chris Buccella <email address hidden>
Date: Thu Jan 30 18:46:08 2014 +0000

    update.py fails silently if module is not found

    update.py can be used to copy individual modules into OpenStack components by
    using the --modules switch and providing a module name. However, if this module
    is not found is oslo, the user is not informed that the copy failed. Print a
    message in this case, and provide the path to the file that the script tried
    to copy.

    Change-Id: I6f811cd9a412d83a4d83f29c8f8398ca0503f7f4
    Closes-Bug: #1274647

Changed in oslo:
status: In Progress → Fix Committed
Changed in oslo:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.