nova-network bridge setup fails if the interface address has 'dynamic' flag

[Xavier Queralt]

While setting the bridge up, if the network interface has a dynamic address, the 'dynamic' flag will be displayed in the "ip addr show" command:

[fedora@dev1 devstack]$ ip addr show dev eth0 scope global
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 52:54:00:00:00:01 brd ff:ff:ff:ff:ff:ff
    inet 192.168.122.2/24 brd 192.168.122.255 scope global dynamic eth0
       valid_lft 2225sec preferred_lft 2225sec

When latter executing "ip addr del" with the IPv4 details, the 'dynamic' flag is not accepted, causes the command to crash and leaves the bridge half configured.

[Xavier Queralt (xqueralt-deactivatedaccount)]

Patch available in gerrit: https://review.openstack.org/70164

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/70164
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0d447f6edd406547e828c592823ac6624e56e91f
Submitter: Jenkins
Branch: master

commit 0d447f6edd406547e828c592823ac6624e56e91f
Author: Xavier Queralt <email address hidden>
Date: Thu Jan 30 17:28:31 2014 +0100

    Ignore 'dynamic' addr flag on bridge configuration

    When setting the bridge up, if that flag is present but not
    ignored, the delete command will fail and may leave the
    interface and the bridge in an inconsistent state.

    Closes-Bug: #1274611
    Related-Bug: #1077066
    Change-Id: Iff65d61d724d0de5d8173ac37f7f748aa23e5d8b

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/havana
Review: https://review.openstack.org/115888

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/116150

[OpenStack Infra (hudson-openstack)]

Change abandoned by Can ZHANG (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/116150
Reason: sorry, duplicate patch

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alan Pevec (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/115888
Reason: https://review.openstack.org/116150 is the correct backport

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116150
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6cbbb615787844d6d0f084e16605d30b56079c97
Submitter: Jenkins
Branch: stable/havana

commit 6cbbb615787844d6d0f084e16605d30b56079c97
Author: Xavier Queralt <email address hidden>
Date: Thu Jan 30 17:28:31 2014 +0100

    Ignore 'dynamic' addr flag on bridge configuration

    When setting the bridge up, if that flag is present but not
    ignored, the delete command will fail and may leave the
    interface and the bridge in an inconsistent state.

    Closes-Bug: #1274611
    Related-Bug: #1077066
    Change-Id: Iff65d61d724d0de5d8173ac37f7f748aa23e5d8b
    (cherry picked from commit 0d447f6edd406547e828c592823ac6624e56e91f)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/145378

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145378
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=40661b11a8e1cbb843b996ec48925b24bb53001c
Submitter: Jenkins
Branch: master

commit 40661b11a8e1cbb843b996ec48925b24bb53001c
Author: Tomoki Sekiyama <email address hidden>
Date: Tue Jan 6 17:57:29 2015 -0500

    Ignore 'dynamic' addr flag on gateway initialization

    When initializing the gateway device, if 'dynamic' flag is present
    but not ignored, the 'ip addr del' command will fail and nova-network
    will fail to startup.
    In LinuxBridgeInterfaceDriver, it is correctly ignored.
    This adds the same handling of flags in initialize_gateway_device.

    Change-Id: Id03e9659a5bec549d6b119cd0ced595875baf0c9
    Closes-Bug: #1408142
    Related-Bug: #1274611