OPENSTACK_NEUTRON_NETWORK settings Are Not Parameterized

Bug #1274382 reported by Mark T. Voelker
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
Undecided
Mark T. Voelker
Havana
Fix Released
Undecided
Unassigned

Bug Description

Horizon can provide GUI support for Neutron's LBaaS, FWaaS, and various other services. However the settings to enable these are currently hardcoded in the template and not parameterized in the manifest. Using 'enable_lb' as an example:

https://github.com/stackforge/puppet-horizon/blob/3.0.0/templates/local_settings.py.erb#L176

In order to enable the LBaaS and other services in Horizon, we need to add a parameter hash to init.pp and set appropriate defaults for backward compatibility.

Changed in puppet-horizon:
status: New → In Progress
assignee: nobody → Mark T. Voelker (mvoelker)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/70054

summary: - Setting for Neutron LBaaS Service Is Not Parameterized
+ OPENSTACK_NEUTRON_NETWORK settings Are Not Parameterized
description: updated
Changed in puppet-horizon:
assignee: Mark T. Voelker (mvoelker) → Emilien Macchi (emilienm)
Changed in puppet-horizon:
assignee: Emilien Macchi (emilienm) → Mark T. Voelker (mvoelker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.openstack.org/70054
Committed: https://git.openstack.org/cgit/stackforge/puppet-horizon/commit/?id=e2c0e7543a3e73013101fc34567a1850367538b1
Submitter: Jenkins
Branch: master

commit e2c0e7543a3e73013101fc34567a1850367538b1
Author: Mark T. Voelker <email address hidden>
Date: Thu Feb 13 23:38:05 2014 -0500

    Parameterize OPENSTACK_NEUTRON_NETWORK settings

    Horizon can provide GUI support for Neutron's LBaaS, FWaaS, VPNaas,
    and other services. However the settings to enable these is currently
    hardcoded in the local_settings.py.erb template rather than being
    parameterized, making it impossible for users to enable support for
    these functions. This patch adds a parameter hash to enable users to
    select how they want to configure Neutron services and sets default
    values to match the old hardcoded settings to maintain backward
    compatibility.

    Change-Id: Ibfa75a83a88d9bb26d65c026c7f913e000bce13f
    Closes-Bug: #1274382

Changed in puppet-horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/74558

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/havana)

Reviewed: https://review.openstack.org/74558
Committed: https://git.openstack.org/cgit/stackforge/puppet-horizon/commit/?id=2d97fbda832c483800d413298929e9a1f73d32b7
Submitter: Jenkins
Branch: stable/havana

commit 2d97fbda832c483800d413298929e9a1f73d32b7
Author: Mark T. Voelker <email address hidden>
Date: Thu Feb 13 23:38:05 2014 -0500

    Parameterize OPENSTACK_NEUTRON_NETWORK settings

    Horizon can provide GUI support for Neutron's LBaaS, FWaaS, VPNaas,
    and other services. However the settings to enable these is currently
    hardcoded in the local_settings.py.erb template rather than being
    parameterized, making it impossible for users to enable support for
    these functions. This patch adds a parameter hash to enable users to
    select how they want to configure Neutron services and sets default
    values to match the old hardcoded settings to maintain backward
    compatibility.

    Conflicts:
     manifests/init.pp
     spec/classes/horizon_init_spec.rb

    Change-Id: Ibfa75a83a88d9bb26d65c026c7f913e000bce13f
    Closes-Bug: #1274382
    (cherry picked from commit e2c0e7543a3e73013101fc34567a1850367538b1)

tags: added: in-stable-havana
Mathieu Gagné (mgagne)
Changed in puppet-horizon:
milestone: none → 4.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.