FilterGrid backed by FilterProxyModel renders wrong

Bug #1274095 reported by Michał Karnicki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Invalid
Medium
Unassigned

Bug Description

While working on a different bug I noticed that FilterGrid would occasionally not render properly when backed by LimitProxyModel.

To give you an example:
$ bzr branch -r657 lp:~unity-team/unity8/unity8-fix-filtergrid
tests/qmltests/Components/tst_FilterGrid
Wraps the fakeModel with LimitProxyModel, and sets that on the filterGrid as the backing model.
$ make -C builddir tryFilterGrid
Consdering collapsedRowCount: 2, columns: 3, now select "model count limit" value
4 (4 items shown, 3+1), then
1 (1 item shown), then
4 (*3* items shown, 3+0) -- second row should show one more item.
Note that "rowsWhenCollapsed" displays value of 2, which would be correct (that would be the actual value of collapsedRowCount).

Now select:
3 (3 items shown), then
4 (*4* items shown, 3+1) -- only now the behavior is correct!

In other words, items displayed on the second row seem to "kick in" only after model grows while it previously filled up the whole first row (or, for that matter, you could generalize to the last row being visible in the FilterGrid, smaller than collapsedRowCount).

As you see, changing the count of items in the model should not affect how many items FilterGrid shows (/renders). And even though rowsWhenCollapsed is calculated correctly, items are missing. Try selecting "model count limit" to 1, then 7. You'll only see 3. If you, however, set 3, then 7, you'll see 6!

Michał Sawicz (saviq)
Changed in unity8:
status: New → Triaged
importance: Undecided → Medium
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Michał Sawicz (saviq)
no longer affects: unity8
Revision history for this message
Albert Astals Cid (aacid) wrote :

Karni is this still happening/important as to have a bug open?

Changed in unity8 (Ubuntu):
status: Triaged → Incomplete
Revision history for this message
Michał Karnicki (karni) wrote :

This bug is 1.5 years old, unless you consider it important based on the description (which I hope is detailed enough), please feel free to drive the bug however you decide, thanks. If Unity8 is still using FilterGrid, I believe it would be worth investigating, but I currently don't have the capacity to help, I'm sorry :(

Changed in unity8 (Ubuntu):
status: Incomplete → New
Revision history for this message
Albert Astals Cid (aacid) wrote :

There's no filtergrid anymore

Changed in unity8 (Ubuntu):
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.