Error message is malformed when removing a non-existent security group from an instance

Bug #1273266 reported by Phil Day
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Phil Day

Bug Description

Trying to remove a security group from an instance which is not actually associated with the instance produces the following:

---
$nova remove-secgroup 71069945-5bea-4d53-b6ab-9026bfeebba4 phil

ERROR: [u'Security group %(security_group_name)s not assocaited with the instance %(instance)s', {u'instance': u'71069945-5bea-4d53-b6ab-9026bfeebba4', u'security_group_name': u'phil'}] (HTTP 404) (Request-ID: req-a334b53d-e7cc-482c-9f1f-7bc61b8367e0)

---

The variables are not being populated correctly, and there is a typo: " assocaited"

Phil Day (philip-day)
Changed in nova:
importance: Undecided → Low
assignee: nobody → Phil Day (philip-day)
milestone: none → icehouse-3
Matt Riedemann (mriedem)
Changed in nova:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/69411

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/69411
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=11d8dc7b9eed0e293ac5afab4792d8af7b807f4c
Submitter: Jenkins
Branch: master

commit 11d8dc7b9eed0e293ac5afab4792d8af7b807f4c
Author: Phil Day <email address hidden>
Date: Mon Jan 27 16:51:55 2014 +0000

    Error message is malformed when removing a sec group from an instance

    In the current code the Error message string for a security group which is not
    associated with an instance does not get expanded correctly, resulting in users
    getting a message:

    ERROR: [u'Security group %(security_group_name)s not assocaited with the
    instance %(instance)s', {u'instance': u'71069945-5bea-4d53-b6ab-9026bfeebba4',
    u'security_group_name': u'phil'}]

    In addition fix a minor typo in this message, and clean up a few cases where
    error messages are not being passed through _() for i18n.

    Change-Id: I85856a135a62bc3415a355e0900ea12ea55f73ae
    Closes-Bug: #1273266

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.