trunk: crashes related to <image> elements (rev 12978)

[su_v]

Reproduced with r12978 inkscape-trunk PPA on Ubuntu 13.04 (VM, 64bit) as well as with local builds on OS X 10.7.5.

Related console message:
** (inkscape:31140): CRITICAL **: void SPObject::detach(SPObject*): assertion 'object->parent == this' failed

AFAICT once such a warning was output to the console, apparently the next encounter with an <image> element (including previews in file dialogs) crashes inkscape r12978.

Various steps to reproduce the crash:
- select a template in 'File > New > Templates…'
- create bitmap copies
- browse directories with bitmap images and SVG documents
- import a bitmap image
- duplicate a linked or embedded image (e.g. after opening a bitmap image directly)
- …

Based on tests with archived builds on OS X 10.7.5:
- not reproduced with rev <= 12977,
- reproduced with rev 12978;
the regression seems to have been introduced with latest revision:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12978>

[su_v (suv-lp)]

Sample backtrace from
> - select a template in 'File > New > Templates…'

[su_v (suv-lp)]

Sample backtrace from
> - import a bitmap image
(preview in file dialog disabled to prevent crash right on selection of the file; default import options)

[jazzynico (jazzynico)]

Reproduced on Crunchbang Waldorf, Inkscape trunk revision 12978.

[su_v (suv-lp)]

@Martin - could you please take a look at this regression?

[su_v (suv-lp)]

No longer reproduced with r12984 (reverts partial refactoring of sp-image) on OS X 10.7.5.

@Mathog - can you confirm the same with your Linux builds (bug #1273900)?

[David Mathog (mathog)]

revision 12984 works. (Doesn't crash as noted above, images seem to be handled properly.)