Evergreen

use getElementById instead of querySelector

Bug #1272575 reported by Jason Etheridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.6.0-beta1

Bug Description

In table.tt2 for the TPAC, we use document.querySelector in a few places where we could use document.getElementById. This breaks k-meleon (horrors, I know). I've pushed a fix here:

collab/phasefx/no_query_selector @ working/Evergreen.git
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/no_query_selector

Revision history for this message
Ben Shum (bshum) wrote :

Adding an initial target so that this doesn't get lost in the winds of "pullrequest" tickets with no target milestone for review.

Changed in evergreen:
milestone: none → 2.6.0-beta1
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Jeff Godin (jgodin) wrote :

No issue with testing, and while I make no commitment to supporting K-Meleon, I note that we're not doing anything here that requires document.querySelector.

document.getElementById is both more compatible and currently appears to have the edge in terms of performance. For those reasons in roughly that order, I've pushed to master. Thanks, Jason!

Changed in evergreen:
status: Triaged → Fix Committed
tags: removed: pullrequest
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.