Use stars like in Music instead of a single image
Bug #1272573 reported by
Danielle Foré
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Photos |
Fix Released
|
Low
|
meese |
Bug Description
Currently the stars in Shotwell are made up of like 7 images depicting different numbers of stars.
We should borrow the star rating widget from Music instead to use system icons and avoid another menu.
Related branches
lp:~meese/pantheon-photos/fix-1272573
- Danielle Foré: Approve (ux)
- Photos Devs: Pending (code) requested
-
Diff: 508 lines (+124/-223)6 files modifiedsrc/CollectionPage.vala (+3/-2)
src/MediaPage.vala (+48/-98)
src/Page.vala (+31/-6)
src/PhotoPage.vala (+38/-93)
ui/collection.ui (+2/-12)
ui/photo_context.ui (+2/-12)
Changed in pantheon-photos: | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in pantheon-photos: | |
status: | Confirmed → In Progress |
assignee: | nobody → Victor Martinez (victored) |
Changed in pantheon-photos: | |
assignee: | Erasmo Marín (erasmo-marin) → meese (madelynn-r-may) |
milestone: | none → freya-beta2 |
Changed in pantheon-photos: | |
status: | In Progress → Fix Committed |
Changed in pantheon-photos: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think the problem here is that photos is not using the stars from the icon theme. So, a solution to this problem, is to get the icons from the teme in execution time and draw the stars dinamically.
The rating widget in noise is not part of Granite, so, it's not standar in Granite apps. I think the best solution is to draw the icons dinamically because that way we don't need to change the way that photos uses to handle the rating system.
Let me know what do you think of my solution, if you agree I can do something about it.