Use stars like in Music instead of a single image

[Danielle Foré]

Currently the stars in Shotwell are made up of like 7 images depicting different numbers of stars.

We should borrow the star rating widget from Music instead to use system icons and avoid another menu.

[Erasmo Marín (erasmo-marin)]

I think the problem here is that photos is not using the stars from the icon theme. So, a solution to this problem, is to get the icons from the teme in execution time and draw the stars dinamically.

The rating widget in noise is not part of Granite, so, it's not standar in Granite apps. I think the best solution is to draw the icons dinamically because that way we don't need to change the way that photos uses to handle the rating system.

Let me know what do you think of my solution, if you agree I can do something about it.

[Danielle Foré (danrabbit)]

Hey Erasmo,

I'm not 100% sure what you mean :p But yes the main problem is that Photos is using it's own images instead of the theme icons.

I do believe that we need to change the interaction as well as the images. The interaction right now in Photos is pretty silly compared to Noise where you can just click directly into the star-rating widget. I would like to get rid of the submenu to select star ratings.

[Robert Roth (evfool)]

Hey Victor, are you still working on this?

[Victor Martinez (victored)]

Yes, I've made some progress on this by moving the rating widget from Noise to Granite, and then adapting Photos to use it. The branch is still rough around the edges.

I'm sorry I had forgotten about it. Thanks for reminding me.

[Victor Martinez (victored)]

Hey Erasmo,

Great work in your latest branch! I'm assigning this bug to you for documentation purposes. Feel free to mark it as fixed.

[Erasmo Marín (erasmo-marin)]

I'm not sure if it should be marked as fixed, because there are still some menus with the old style stars. Check the attachment, at left, photos, at right, music.

[meese (meese)]

I brought in the noise widget with the metadata sidebar addition and https://code.launchpad.net/~madelynn-r-may/pantheon-photos/fix-1272573/+merge/232492 adds it to the context menus

[Erasmo Marín (erasmo-marin)]

Great!

There is a branch with a port of that widget to granite widgets, we should use that widget instead, but as you used the same widget and the interface will be at most the same, it will be easy to change.