The _test_{compute,console,network,scheduler}_api methods seem broken.

[Cyril Roelandt]

The _test_{compute,console,network,scheduler}_api methods, found in nova/tests/{compute,console,network,scheduler}/test_rpcapi.py, all have the following line in the beginning:

    expected_retval = 'foo' if method == 'call' else None

However, the "method" parameter is never equal to 'call'. It is probably meant to read:

    expected_retval = 'foo' if rpc_method == 'call' else None

instead.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/72124

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72124
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0b8267aa834e9d86cf2ecd9fd64ccc218df454bd
Submitter: Jenkins
Branch: master

commit 0b8267aa834e9d86cf2ecd9fd64ccc218df454bd
Author: Russell Bryant <email address hidden>
Date: Sat Feb 8 16:28:58 2014 -0500

    Fix a couple of unit test typos

    There were two cases in rpcapi unit tests where it was checking method instead
    of rpc_method. Fix up the typo and the reason why the typo didn't matter
    before. Also fix two places where rpcapi code had a return for a cast(), which
    is now caught by the unit tests.

    Closes-bug: #1272518
    Change-Id: Ib5e3a002f6b0f7eb8dee8bd84bd53dbf817017f7

[Cyril Roelandt (cyril-roelandt)]

@Russell: I think this does not fix the issue for compute/console. See my previous patch at https://review.openstack.org/#/c/69020/ . WDYT ?