sahara api validation for data-sources creation w/ credentials is vague

Bug #1272137 reported by Matthew Farrellee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Low
Andrew Lazarev

Bug Description

creating a data-source w/ a swift type requires both a username and password. the validations for the call correctly identify if one of a username, password or both are missing, but raises a nonspecific error.

def _check_swift_data_source_create(data):
    if not ("user" in data["credentials"]
            and "password" in data["credentials"]):
        raise ex.InvalidCredentials("Invalid credentials for Swift")

it would be better to raise an error that specifies precisely what is missing

Changed in savanna:
milestone: none → next
importance: Undecided → Medium
status: New → Confirmed
Changed in sahara:
assignee: nobody → Andrew Lazarev (alazarev)
status: Confirmed → In Progress
Changed in sahara:
milestone: next → juno-1
Changed in sahara:
importance: Medium → Low
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/88092
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=c17d7950b7c51996eec6bd55e36fd3816bdf7fe1
Submitter: Jenkins
Branch: master

commit c17d7950b7c51996eec6bd55e36fd3816bdf7fe1
Author: Andrew Lazarev <email address hidden>
Date: Wed Apr 16 14:49:30 2014 -0700

    Improved validation for data-sources creation

    Change-Id: Ia9734e209ca6fd68ccb0261bc2421da9f88b315a
    Closes-Bug: #1272137

Changed in sahara:
status: In Progress → Fix Committed
summary: - savanna api validation for data-sources creation w/ credentials is vague
+ sahara api validation for data-sources creation w/ credentials is vague
Thierry Carrez (ttx)
Changed in sahara:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in sahara:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.