savannaclient allows for creation of swift data sources without credentials
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Python client library for Sahara |
Fix Released
|
Medium
|
Matthew Farrellee |
Bug Description
the savanna-api side validations for data-sources creation require presence of a user and password when a swift type is provided
def _check_
if not ("user" in data["credentials"]
and "password" in data["credentia
raise ex.InvalidCrede
however, the savannaclient always provides a user and password, even if they are None
def create(self, name, description, data_source_type,
url, credential_user, credential_pass):
data = {
'name': name,
'type': data_source_type,
'url': url,
}
return self._create(
the client effectively cancels out the service validation
Changed in savanna: | |
assignee: | nobody → Matthew Farrellee (mattf) |
importance: | Undecided → Low |
milestone: | none → icehouse-3 |
affects: | savanna → python-savannaclient |
Changed in python-savannaclient: | |
milestone: | icehouse-3 → none |
milestone: | none → 0.5.0 |
importance: | Low → Medium |
Changed in python-savannaclient: | |
status: | Fix Committed → Fix Released |
fixed by - 01a096d5612597f 74f9534b29
commit aaab0505fe1547a
Author: Matthew Farrellee <email address hidden>
Date: Thu Jan 23 20:58:57 2014 -0500
Send credentials only when they are provided
Closes-bug: #1272130
Change-Id: I9a82e52dcadcdc f02ecbadaf23c42 243d59b464a