savannaclient allows for creation of swift data sources without credentials

[Matthew Farrellee]

the savanna-api side validations for data-sources creation require presence of a user and password when a swift type is provided

def _check_swift_data_source_create(data):
    if not ("user" in data["credentials"]
            and "password" in data["credentials"]):
        raise ex.InvalidCredentials("Invalid credentials for Swift")

however, the savannaclient always provides a user and password, even if they are None

    def create(self, name, description, data_source_type,
               url, credential_user, credential_pass):
        data = {
            'name': name,
            'description': description,
            'type': data_source_type,
            'url': url,
            'credentials': {'user': credential_user,
                            'password': credential_pass}
        }
        return self._create('/data-sources', data, 'data_source')

the client effectively cancels out the service validation

[Matthew Farrellee (mattf)]

fixed by -
commit aaab0505fe1547a01a096d5612597f74f9534b29
Author: Matthew Farrellee <email address hidden>
Date: Thu Jan 23 20:58:57 2014 -0500

    Send credentials only when they are provided

    Closes-bug: #1272130

    Change-Id: I9a82e52dcadcdcf02ecbadaf23c42243d59b464a