Not possible to spawn vmware instance with multiple disks

[Matthew Booth]

The behaviour of spawn() in the vmwareapi driver wrt images and block device mappings is currently as follows:

If there are any block device mappings, images are ignored
If there are any block device mappings, the last becomes the root device and all others are ignored

This means that, for example, the following scenarios are not possible:

1. Spawn an instance with a root device from an image, and a secondary volume
2. Spawn an instance with a volume as a root device, and a secondary volume

The behaviour of the libvirt driver is as follows:

If there is an image, it will be the root device unless there is also a block device mapping for the root device
All block device mappings are used
If there are multiple block device mappings for the same device, the last one is used

The vmwareapi driver's behaviour is surprising, and should be modified to follow the libvirt driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/95858

[zhu zhu (zhuzhubj)]

Is someone still working on this issue?

[Arnaud Legendre (arnaudleg)]

Please see my update on the review. Thanks

[zhu zhu (zhuzhubj)]

See comments in the code review. Thanks.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Arnaud Legendre (<email address hidden>) on branch: master
Review: https://review.openstack.org/95858

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/122872

[OpenStack Infra (hudson-openstack)]

Change abandoned by Arnaud Legendre (<email address hidden>) on branch: master
Review: https://review.openstack.org/122872
Reason: in favor of Ibf59906b95bda560d2427c88a78b65c098825959

[Davanum Srinivas (DIMS) (dims-v)]

Latest seems to be https://review.openstack.org/#/c/128508/

[Davanum Srinivas (DIMS) (dims-v)]

Fix proposed again by Thang

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/128508
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=264425678fd4a37618c2bceae8e62f6bba778223
Submitter: Jenkins
Branch: master

commit 264425678fd4a37618c2bceae8e62f6bba778223
Author: Thang Pham <email address hidden>
Date: Tue Oct 14 23:24:54 2014 -0400

    VMware: Accept image and block device mappings

    The logic in spawn ignores the specified image if there
    are block device mappings in "nova boot". This is incorrect
    and is a bug in the VMware driver, since the block devices
    can be blank volumes. We should be able to accept an image
    and block device mappings in "nova boot".

    DocImpact: VMware supports nova boot with the --block-device
    option. End users can specify the block device's bus to be
    either lsiLogic, busLogic, ide, lsiLogicsas, or paraVirtual.
    For example, nova boot --flavor m1.tiny --block-device
    source=image,dest=volume,size=1,id=<image_id>,bus=lsiLogicsas,
    bootindex=0 test

    Change-Id: Ibf59906b95bda560d2427c88a78b65c098825959
    Closes-Bug: #1350224
    Closes-Bug: #1271966