faults in Pulsars plugin database

[Colin J Denman]

In 0.12.4 pulsars.json:
At least, the Dec positions of these are faulty. Parsing of these DE
strings DOES NOT RESULT IN A LOG ERROR:
PSR J0034-0534 -5d634m36.622s
PSR J0134-2937 -29d3517m16.912s
PSR J0448-2749 -27d3289m46.735s
PSR J0459-0210 -2d250m6.632s
PSR J0520-2553 -25d3053m12.293s
PSR J0725-1635 -16d1955m45.815s
PSR J0729-1836 -18d2196m42.750s
PSR J0828-3417 -34d4097m7.048s
PSR J0846-3533 -35d4233m40.653s
PSR J0855-3331 -33d3991m39.304s
PSR J1012-2337 -23d2798m22.421s
PSR J1018-1642 -16d1962m10.139s
PSR J1034-3224 -32d3864m25.981s
...
from a visual inspection of the first 3784 lines of a 24000+ line file.

The following entry DOES yield a log error
PSR J1817-1938 getDecAngle failed to parse angle string: "-19d38.6m00s"

Needing attention:
1. Stellarium getDecAngle probably needs some work to report bad angles to the log file.
2. pulsars.json needs regenerating via corrected version of whatever software produced the errors above. There may be many more such errors in the current file. I have only looked for similar errors in DE entries.

[Alexander Wolf (alexwolf)]

Please update pulsars catalog via plugin tool.

[Colin J Denman (denman-colin)]

Updated as requested, changes to faults noted. Log:

Loaded plugin "Pulsars" .
Pulsars::getJsonFileFormatVersion() version of format from file: 2
Pulsars::init using file: "/home/colin/.stellarium/modules/Pulsars/pulsars.json"

catalog.json seems ok, but the data faults remain in pulsars.json. Is this file now redundant? If so, why is the log reporting its use?

[Alexander Wolf (alexwolf)]

catalog.json is redundant now.

Following lines says:
Loaded plugin "Pulsars" . - plugin was successfully loaded
Pulsars::getJsonFileFormatVersion() version of format from file: 2 - ok, plugin checked version for catalog format - 2 for 0.12.4 is ok
Pulsars::init using file: "/home/colin/.stellarium/modules/Pulsars/pulsars.json" - use catalog of pulsars - all ok

Seems you are don't have troubles now :)

[Alexander Wolf (alexwolf)]

Catalog diff: http://bazaar.launchpad.net/~stellarium/stellarium-website/trunk/revision/444

Plugin diffs:
a) main changes - http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/6512
b) fixes and simplification - http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/6513

[Colin J Denman (denman-colin)]

Many thanks