libvirt._create_image is too large and not tested

Bug #1271528 reported by Sahid Orentino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Sahid Orentino

Bug Description

We need to split this method is several small and add tests.

Tags: libvirt
Changed in nova:
assignee: nobody → sahid (sahid-ferdjaoui)
Changed in nova:
status: New → In Progress
Revision history for this message
Sahid Orentino (sahid-ferdjaoui) wrote :
summary: - libvirt: injected_file is not supported for volume but still executed
+ libvirt._create_image is too large and not tested
description: updated
tags: added: libvirt
Changed in nova:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/77593

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/68604
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b1a8b39bfb13602556bbb2c3cb3d93673393f947
Submitter: Jenkins
Branch: master

commit b1a8b39bfb13602556bbb2c3cb3d93673393f947
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Mon Mar 3 13:13:19 2014 +0100

    Add helper method for checking if VM is booting from a volume

    Add a _is_booted_from_value method which determines whether
    the disk mapping indicates that the VM is booting from a volume
    Update the _create_image method to use this helper API.

    Related-Bug: #1271528
    Change-Id: Iaa92f84ad3de9e84ba49bb255add043f3c8e4c8f

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/77593
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a4a19293f82255cf98d3239fbf1f16bcb410143c
Submitter: Jenkins
Branch: master

commit a4a19293f82255cf98d3239fbf1f16bcb410143c
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Mon Mar 3 15:06:33 2014 +0100

    Add helper method for injecting data in an image

    Add a _inject_data method whish helps to injecting data
    in a disk image file system.
    Update the _create_image method to use this helper

    Change-Id: Ia005eee0a34d77bbf3eb33f7fef231dcf1eabe2c
    Related-Bug: #1271528

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.