I18n: untranslated help text for port create

Bug #1271348 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Doug Fish

Bug Description

In Admin->Networks->[network name]->Ports->Create Port, the Device ID and Device Owner have untranslated tool tips. Looks like the issue is in openstack_dashboard/dashboards/admin/networks/ports/forms.py

Doug Fish (drfish)
Changed in horizon:
assignee: nobody → Doug Fish (drfish)
Revision history for this message
Victoria Martinez de la Cruz (vkmc) wrote :

In the file you mention, https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/networks/ports/forms.py#L46, the strings Device ID and Device Owner are translatable. Maybe those haven't been translated yet?

Revision history for this message
Doug Fish (drfish) wrote :

Good thought, but our globalization team discovered this one by making a mock translation. Most elements of the screen were translated, but these strings remained in English. Taking a closer look, I see they don't use the translation function "_", so they aren't translatable.

The good news is that it should be a very easy fix. I'm taking a bit more time that you might expect because this is my first OS code contribution and I'm being careful to get the pieces in the right place, do the right tests, etc.

Revision history for this message
Doug Fish (drfish) wrote :

oh - and the strings that aren't translatable are the help text: "Device ID attached to the port", and "Device owner attached to the port"

Revision history for this message
Victoria Martinez de la Cruz (vkmc) wrote :

I saw those yeah, thought you were talking about the labels.

Thanks for working on this!

Changed in horizon:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/68452

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/68452
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7ce85bc391804d5b9b34de98271acb1dcc1a1a34
Submitter: Jenkins
Branch: master

commit 7ce85bc391804d5b9b34de98271acb1dcc1a1a34
Author: Doug Fish <email address hidden>
Date: Wed Jan 22 09:11:36 2014 -0600

    Make hardcoded fields translatable

    In Admin->Networks->[network name]->Ports->Create Port, the Device ID and
    Device owner have untranslated help_text values, which get displayed as
    tool tips in the UI. This change adds the translation function to those
    pieces of text. Also fixing the Edit Port parts as well.

    Change-Id: Iaddd58b50cda818e332f8bead5a02b07916a2f58
    Closes-Bug: #1271348

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.