Clean up unused exceptions

[aeva black]

We should clean up unused exceptions from ironic.common.exceptions, or figure out why they were added and raise them in the appropriate places.

$ cd ironic/ironic
$ for e in $(grep -P '^class ' common/exception.py | sed 's/(/ /' | awk '{print $2}'); do l=$(grep -rP "raise .*\.$e" . | wc -l); if [ $l == 0 ]; then l=$(grep "($e):" common/exception.py | wc -l); fi; if [ $l == 0 ]; then echo $e; fi ; done

AdminRequired
PolicyNotAuthorized
InvalidCPUInfo
InvalidIpAddressError
InvalidDiskFormat
DiskNotFound
HostNotFound
ConsoleNotFound
FileNotFound
NoValidHost
NodeInUse
NodeNotConfigured
ImageNotAuthorized
HTTPException
InvalidEndpoint
CommunicationError

[Michael Davies (mrda)]

I've reviewed the current code and this exception list, and I don't think there's any immediate use for these exceptions.

I'm recommending deleting them.

[Michael Davies (mrda)]

Actually...

ImageNotAuthorized
InvalidEndpoint
CommunicationError

...are required as are propagated from glance.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/68852

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/68852
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=77ea8ae5a977558dee45a7a0bfc2ea0669de9816
Submitter: Jenkins
Branch: master

commit 77ea8ae5a977558dee45a7a0bfc2ea0669de9816
Author: Michael Davies <email address hidden>
Date: Thu Jan 23 21:42:03 2014 -0800

    Removed unused exceptions

    There's a bunch of exceptions that were copied over from nova-baremetal
    into ironic that are currently unused and don't have any immediate
    applicability.

    Change-Id: Ia5a3c25ca809edcfeaefd423609b43f2658f1870
    Closes-Bug: 1271283