_last_vol_usage_poll was not properly updated

[Haiwei Xu]

I found this error in jinkins's log: http://logs.openstack.org/02/67402/4/check/gate-nova-python27/b132ac8/console.html

2014-01-20 02:36:59.295 | ======================================================================
2014-01-20 02:36:59.295 | FAIL: nova.tests.compute.test_compute.ComputeVolumeTestCase.test_poll_volume_usage_with_data
2014-01-20 02:36:59.295 | tags: worker-0
2014-01-20 02:36:59.296 | ----------------------------------------------------------------------
2014-01-20 02:36:59.296 | Empty attachments:
2014-01-20 02:36:59.296 | stderr
2014-01-20 02:36:59.296 | stdout
2014-01-20 02:36:59.297 |
2014-01-20 02:36:59.297 | pythonlogging:'': {{{
2014-01-20 02:36:59.297 | INFO [nova.virt.driver] Loading compute driver 'nova.virt.fake.FakeDriver'
2014-01-20 02:36:59.298 | AUDIT [nova.compute.resource_tracker] Auditing locally available compute resources
2014-01-20 02:36:59.298 | AUDIT [nova.compute.resource_tracker] Free ram (MB): 7680
2014-01-20 02:36:59.298 | AUDIT [nova.compute.resource_tracker] Free disk (GB): 1028
2014-01-20 02:36:59.299 | AUDIT [nova.compute.resource_tracker] Free VCPUS: 1
2014-01-20 02:36:59.299 | INFO [nova.compute.resource_tracker] Compute_service record created for fake-mini:fakenode1
2014-01-20 02:36:59.299 | AUDIT [nova.compute.manager] Deleting orphan compute node 2
2014-01-20 02:36:59.300 | }}}
2014-01-20 02:36:59.300 |
2014-01-20 02:36:59.300 | Traceback (most recent call last):
2014-01-20 02:36:59.300 | File "nova/tests/compute/test_compute.py", line 577, in test_poll_volume_usage_with_data
2014-01-20 02:36:59.301 | self.compute._last_vol_usage_poll)
2014-01-20 02:36:59.301 | File "/usr/lib/python2.7/unittest/case.py", line 420, in assertTrue
2014-01-20 02:36:59.301 | raise self.failureException(msg)
2014-01-20 02:36:59.302 | AssertionError: _last_vol_usage_poll was not properly updated <1390185067.18>

[Matt Riedemann (mriedem)]

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiRkFJTDogbm92YS50ZXN0cy5jb21wdXRlLnRlc3RfY29tcHV0ZS5Db21wdXRlVm9sdW1lVGVzdENhc2UudGVzdF9wb2xsX3ZvbHVtZV91c2FnZV93aXRoX2RhdGFcIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiNjA0ODAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTM5MDUwOTI4OTc5OH0=

[Matt Riedemann (mriedem)]

e-r query patch https://review.openstack.org/#/c/68762/

[Matt Riedemann (mriedem)]

nova patch is here: https://review.openstack.org/#/c/68768/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/68768
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7e18d67cc9c96a14e0ca24a41820441e41457738
Submitter: Jenkins
Branch: master

commit 7e18d67cc9c96a14e0ca24a41820441e41457738
Author: Russell Bryant <email address hidden>
Date: Thu Jan 23 16:03:37 2014 -0500

    Make test_poll_volume_usage_with_data more reliable

    This test includes 2 calls to time.time(). It assumes that the result
    from the second call may be greater than the first. This isn't
    definietly true and we see periodic failures of this test in the gate as
    a result.

    Change the test to not worry about the specific time value that gets
    set. We set _last_vol_usage_poll to 0 before calling the function under
    test. We really only need to check that it got set to some value after
    calling the function under test. This tweak should make the test pass
    consistently.

    Change-Id: I6c01d2958cf671c29622562689a15ca1ddea0a3c
    Closes-bug: #1270693

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/68920

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/69018

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/68920
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b69f2ca7b2bb6bf5788b16fd21800f53a6ec4807
Submitter: Jenkins
Branch: stable/havana

commit b69f2ca7b2bb6bf5788b16fd21800f53a6ec4807
Author: Russell Bryant <email address hidden>
Date: Thu Jan 23 16:03:37 2014 -0500

    Make test_poll_volume_usage_with_data more reliable

    This test includes 2 calls to time.time(). It assumes that the result
    from the second call may be greater than the first. This isn't
    definietly true and we see periodic failures of this test in the gate as
    a result.

    Change the test to not worry about the specific time value that gets
    set. We set _last_vol_usage_poll to 0 before calling the function under
    test. We really only need to check that it got set to some value after
    calling the function under test. This tweak should make the test pass
    consistently.

    Change-Id: I6c01d2958cf671c29622562689a15ca1ddea0a3c
    Closes-bug: #1270693
    (cherry picked from commit 7e18d67cc9c96a14e0ca24a41820441e41457738)