test_different_fname_concurrency flakey fail

[Christopher Yeoh]

Looks like test_different_fname_concurrency has an intermittent fail

ft1.9289: nova.tests.virt.libvirt.test_libvirt.CacheConcurrencyTestCase.test_different_fname_concurrency_StringException: Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "nova/tests/virt/libvirt/test_libvirt.py", line 319, in test_different_fname_concurrency
    self.assertTrue(done2.ready())
  File "/usr/lib/python2.7/unittest/case.py", line 420, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true

Full logs here: http://logs.openstack.org/91/58191/4/check/gate-nova-python27/413d398/testr_results.html.gz

[Joe Gordon (jogo)]

logstash query: message:"test_different_fname_concurrency" AND build_name:*nova-python2*

[Joe Gordon (jogo)]

setting to critical as this is being seen in the gate

[Davanum Srinivas (DIMS) (dims-v)]

This bug already has a review - https://review.openstack.org/#/c/68443/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/68443
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a35776d337493b14d2937f0f4a03aa4b119d018b
Submitter: Jenkins
Branch: master

commit a35776d337493b14d2937f0f4a03aa4b119d018b
Author: Russell Bryant <email address hidden>
Date: Wed Jan 22 12:09:11 2014 -0500

    Make test_different_fname_concurrency less racy

    This test case makes a bad assumption about when a greenthread will run
    and signal its done event. The test code yields once using a sleep and
    expects that the done event will get signaled before the test code runs
    again. This may not be the case. Instead, yield up to 10 times waiting
    for the done event to occur.

    I was not able to reproduce this failure locally, but we're seeing it
    regularly in CI. It seems that this should resolve it.

    Change-Id: I978ae9eef5bb1ac296055dc1613406e4284a625f
    Closes-bug: #1270654

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/68922

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/68986

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/68922
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f11e9275004ac3cc392cee346e5d7b4a7528fbe7
Submitter: Jenkins
Branch: stable/havana

commit f11e9275004ac3cc392cee346e5d7b4a7528fbe7
Author: Russell Bryant <email address hidden>
Date: Wed Jan 22 12:09:11 2014 -0500

    Make test_different_fname_concurrency less racy

    This test case makes a bad assumption about when a greenthread will run
    and signal its done event. The test code yields once using a sleep and
    expects that the done event will get signaled before the test code runs
    again. This may not be the case. Instead, yield up to 10 times waiting
    for the done event to occur.

    I was not able to reproduce this failure locally, but we're seeing it
    regularly in CI. It seems that this should resolve it.

    Change-Id: I978ae9eef5bb1ac296055dc1613406e4284a625f
    Closes-bug: #1270654
    (cherry picked from commit a35776d337493b14d2937f0f4a03aa4b119d018b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/68986
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a9e5391bac9899d041539f7ecf226af57fc96520
Submitter: Jenkins
Branch: stable/grizzly

commit a9e5391bac9899d041539f7ecf226af57fc96520
Author: Russell Bryant <email address hidden>
Date: Wed Jan 22 12:09:11 2014 -0500

    Make test_different_fname_concurrency less racy

    This test case makes a bad assumption about when a greenthread will run
    and signal its done event. The test code yields once using a sleep and
    expects that the done event will get signaled before the test code runs
    again. This may not be the case. Instead, yield up to 10 times waiting
    for the done event to occur.

    I was not able to reproduce this failure locally, but we're seeing it
    regularly in CI. It seems that this should resolve it.

    Change-Id: I978ae9eef5bb1ac296055dc1613406e4284a625f
    Closes-bug: #1270654
    (cherry picked from commit a35776d337493b14d2937f0f4a03aa4b119d018b)