Show HTTPInternalServerError when getting meter statistics with invalid date string in query

Bug #1270394 reported by Liusheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Liusheng

Bug Description

When using "ceilometer statistics -m instance -q end=123" to get a meter statistics with invalid data string in query.
the ceilometer API return:
    {"error_message": {"debuginfo": null, "faultcode": "Server", "faultstring": "Unable to parse date string u'123'"}}
But the ceilometer CLI return:
    WARNING (http:172) Request returned failure status.
    HTTPInternalServerError (HTTP 500)

I think ceilometerclient should return the details of error.

Liusheng (liusheng)
Changed in python-ceilometerclient:
assignee: nobody → Liusheng (liusheng)
Liusheng (liusheng)
affects: python-ceilometerclient → ceilometer
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/81775

Changed in ceilometer:
status: New → In Progress
gordon chung (chungg)
Changed in ceilometer:
importance: Undecided → Low
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/90636

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/92786

Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → juno-3
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-3 → juno-rc1
Changed in ceilometer:
assignee: Liusheng (liusheng) → Lianhao Lu (lianhao-lu)
Lianhao Lu (lianhao-lu)
Changed in ceilometer:
assignee: Lianhao Lu (lianhao-lu) → Liusheng (liusheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/92786
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=6c7954ee9d67956c0b6df57aaa9f03a67f39c509
Submitter: Jenkins
Branch: master

commit 6c7954ee9d67956c0b6df57aaa9f03a67f39c509
Author: liu-sheng <email address hidden>
Date: Thu May 8 14:43:45 2014 +0800

    Improve the timestamp validation of ceilometer API

    Currently, ceilometer API is lack of timestamp validation. Timestamp in
    query should be checked if it can be parsed to iso timestamp, and raise
    explicit exception if not.

    Change-Id: I02cb2f30b00bde46bf8a0e4e161a0e2ce9d44c09
    Closes-bug: #1270394

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.